Skip to content

Make component linker allocations fallible#13083

Merged
fitzgen merged 2 commits into
bytecodealliance:mainfrom
fitzgen:component-linker-fallible-allocs
Apr 13, 2026
Merged

Make component linker allocations fallible#13083
fitzgen merged 2 commits into
bytecodealliance:mainfrom
fitzgen:component-linker-fallible-allocs

Conversation

@fitzgen

@fitzgen fitzgen commented Apr 13, 2026

Copy link
Copy Markdown
Member

No description provided.

@fitzgen fitzgen requested a review from a team as a code owner April 13, 2026 22:16
@fitzgen fitzgen requested review from dicej and removed request for a team April 13, 2026 22:16

@alexcrichton alexcrichton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests too?

Comment thread crates/wasmtime/src/runtime/component/linker.rs Outdated
@fitzgen

fitzgen commented Apr 13, 2026

Copy link
Copy Markdown
Member Author

Tests too?

I have a bunch of OOM tests coming in follow ups, but wanted to separate this into its own PR first so reviewers could focus on actual code changes.

I can pluck them out and and them to this PR if you prefer tho

@fitzgen

fitzgen commented Apr 13, 2026

Copy link
Copy Markdown
Member Author

(Figured that existing tests passing was enough tire-kicking for this PR to land on its own)

@fitzgen fitzgen enabled auto-merge April 13, 2026 22:58
@alexcrichton

Copy link
Copy Markdown
Member

Nah no worries, so long as there's tests eventually 👍

@fitzgen fitzgen added this pull request to the merge queue Apr 13, 2026
Merged via the queue into bytecodealliance:main with commit 9d94576 Apr 13, 2026
48 checks passed
@fitzgen fitzgen deleted the component-linker-fallible-allocs branch April 13, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants