Add OOM test for component Func::call_async#13017
Merged
fitzgen merged 5 commits intoApr 10, 2026
Merged
Conversation
Add NameMap::get_by_str to avoid infallible String allocation in component export name lookups. The NameMapNoIntern implementation allocated a String on every lookup; the new method uses borrowed &str keys directly on the underlying IndexMap instead.
fitzgen
force-pushed
the
handle-oom-in-component-func-call-async
branch
from
ac21e79 to
f4fda42
Compare
alexcrichton
reviewed
Apr 9, 2026
github-actions
Bot
added
fuzzing
Subscribe to Label Actioncc @fitzgen DetailsThis issue or pull request has been labeled: "fuzzing", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Member
Author
|
@alexcrichton want to take another look? Adjusting the trait got pretty big, although it is mostly stuff I've done similar things for in follow-up commits that I haven't pushed up as new PRs yet. |
alexcrichton
approved these changes
Apr 10, 2026
Merged
via the queue into
bytecodealliance:main
with commit Apr 10, 2026
7bd61b8
92 of 96 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add NameMap::get_by_str to avoid infallible String allocation in
component export name lookups. The NameMapNoIntern implementation
allocated a String on every lookup; the new method uses borrowed
&str keys directly on the underlying IndexMap instead.
Depends on #12993