Do not allocate when cloning ModuleRuntimeInfo#12413
Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom Jan 23, 2026
Merged
Do not allocate when cloning ModuleRuntimeInfo#12413fitzgen merged 1 commit intobytecodealliance:mainfrom
ModuleRuntimeInfo#12413fitzgen merged 1 commit intobytecodealliance:mainfrom
Conversation
alexcrichton
approved these changes
Jan 23, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
We need to clone the info from the allocation request, into the allocated instance, so we should keep it a cheap operation.
fitzgen
force-pushed
the
dont-alloc-when-cloning-module-runtime-info
branch
from
75526a9 to
220b9a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to clone the info from the allocation request, into the allocated instance, so we should keep it a cheap operation.