Don't pass module into initialize_vmctx#12412
Merged
fitzgen merged 2 commits intobytecodealliance:mainfrom Jan 23, 2026
Merged
Conversation
Get it from `self`, which means we can't ever pass in the wrong module.
alexcrichton
requested changes
Jan 23, 2026
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
The purpose of this is to avoid the Arc::clone which can be pretty hotly contested here since if many threads instantiate the same module/component that'll cause lots of incs/decs on the same memory location. Historically I don't recall this being a problem here exactly, but we have at least one bug report showing a 30% slowdown in throughput for an optimized host function if we include an Arc::clone by accident.
Instead of a clone, however, how about something like what components do?
alexcrichton
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get it from
self, which means we can't ever pass in the wrong module.