Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winch: Add SIMD float arithmetic support for x64 with AVX #10247

Merged

Conversation

jeffcharles
Copy link
Contributor

Part of #8093. Adds implementations for:

  • f32x4.add
  • f64x2.add
  • f32x4.sub
  • f64x2.sub
  • f32x4.mul
  • f64x2.mul
  • f32x4.div
  • f64x2.div
  • f32x4.neg
  • f64x2.neg
  • f32x4.sqrt
  • f64x2.sqrt

@jeffcharles jeffcharles requested review from a team as code owners February 19, 2025 21:03
@jeffcharles jeffcharles requested review from cfallin and alexcrichton and removed request for a team February 19, 2025 21:03
@alexcrichton alexcrichton requested review from saulecabrera and removed request for alexcrichton February 19, 2025 22:01
@github-actions github-actions bot added the winch Winch issues or pull requests label Feb 19, 2025
Copy link

Subscribe to Label Action

cc @saulecabrera

This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

  • saulecabrera: winch

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Member

@saulecabrera saulecabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@saulecabrera saulecabrera added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
@saulecabrera saulecabrera added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
@jeffcharles
Copy link
Contributor Author

Going to see if merging main into this branch helps

@saulecabrera
Copy link
Member

I think the CI issues should be resolved once #10253 lands.

@alexcrichton alexcrichton added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 20, 2025
@alexcrichton alexcrichton added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
@jeffcharles
Copy link
Contributor Author

There was a missing self.ensure_has_avx()? check in v128_neg so the Wast tests would panic instead of returning an error when the AVX extensions weren't available. I've fixed that in the latest commit.

@saulecabrera saulecabrera added this pull request to the merge queue Feb 20, 2025
Merged via the queue into bytecodealliance:main with commit acef408 Feb 20, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
winch Winch issues or pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants