Winch: Clean up Wast SIMD tests #10203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
approved these changes
Feb 7, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
It's unfortunately buried, but the failure is here |
|
notably: |
|
That makes sense. The tests that were already uncommented probably didn't rely on AVX support, but the tests I uncommented in this PR do rely on it, so the test needs to be added to the unsupported with no AVX list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up some of the Winch SIMD Wast tests. I had initially set these up as copies of the spec testsuite with some instructions commented out so there would be some spec test coverage of what I was implementing. But now it looks like the actual spec testsuite can be used for most of them so I'm deleting them. The exception is
simd_multivaluewhich doesn't have a corresponding spec test so I've renamed it to remove the leading underscore. For the remaining files, I've uncommented tests that should now pass.