Make TOML config keys kebab-case, and add docs #10132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/cli-options.md
Outdated
| assuming the TOML file is called `config.toml`. Of course you can put as many | ||
| key-value pairs as you want in the TOML file. | ||
|
|
||
| > Note: When specifying names in TOML, you must replaces dashes with underscores. In the example above, `opt-level` becomes `opt_level`. |
There was a problem hiding this comment.
For this, could we actually use #[serde(rename_all = "...")] to blanket rename everything to kebab-case? That way it'd be the same on the CLI and in TOML?
There was a problem hiding this comment.
This is a good idea
github-actions
bot
added
the
wasmtime:docs
ludfjig
changed the title
alexcrichton
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the doc for flag introduced in #9811.
Feedback appreciated, happy to change things around. The reason I added some stuff on the --optimize, --debug things were to be able to reference those options in the TOML section.