Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmtime-wit-bindgen: use core instead of std in all emitted code #10105

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

pchickey
Copy link
Contributor

@pchickey pchickey commented Jan 24, 2025

Improve compatibility with #![no_std] builds by substituting all uses of std:: for core:: in wasmtime-wit-bindgen output.

The one use of the std cargo feature in this crate was to gate emitting impl std::error::Error for ..., now that Error is in core we can unconditionally emit an impl core::error::Error for ..., and eliminate the std cargo feature in the wasmtime-wit-bindgen and wasmtime-component-macro crates.

@pchickey pchickey marked this pull request as ready for review January 25, 2025 02:43
@pchickey pchickey requested a review from a team as a code owner January 25, 2025 02:43
@pchickey pchickey requested review from dicej and removed request for a team January 25, 2025 02:43
@alexcrichton alexcrichton added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit f063003 Jan 27, 2025
154 checks passed
@alexcrichton alexcrichton deleted the pch/wasmtime_bindgen_nostd branch January 27, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants