Emit post-optimization CLIF with --emit-clif
#10011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the implementation of the `wasmtime` CLI flag `--emit-clif` to emit the IR post-optimization rather than pre-optimization. This is now emitting the IR that's directly fed to the backend for lowering which reflects any mid-level transformation that's performed. It should still be possible to recover pre-optimized CLIF with `-O opt-level=0`. This then additionally refactors functions to emit CLIF in a more "core" location so all trampolines get their CLIF emitted as well in case those are needed for debugging.
dicej
approved these changes
Jan 14, 2025
|
Looks like all
|
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jan 14, 2025
Just after bytecodealliance#10011 I ran into a case where I wanted to peek at CLIF after compilation failed but the structure of the code failed to enable this, so I've refactored `--emit-clif` to emit the CLIF even if the lowering step fails.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 14, 2025
Just after #10011 I ran into a case where I wanted to peek at CLIF after compilation failed but the structure of the code failed to enable this, so I've refactored `--emit-clif` to emit the CLIF even if the lowering step fails.
Doesn't that still perform legalizations? |
|
That's true yeah, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the implementation of the
wasmtimeCLI flag--emit-clifto emit the IR post-optimization rather than pre-optimization. This is now emitting the IR that's directly fed to the backend for lowering which reflects any mid-level transformation that's performed. It should still be possible to recover pre-optimized CLIF with-O opt-level=0.This then additionally refactors functions to emit CLIF in a more "core" location so all trampolines get their CLIF emitted as well in case those are needed for debugging.