Remove std and core features#137
Conversation
|
Two questions:
|
|
Yeah this'll be a breaking change at least due to the removal of the features. I didn't notice the test script, but I can remove as well! That being said it's probably best to hold off for bytecodealliance/wasmtime#554 first. |
|
@alexcrichton Now that wasmtime has now removed the std features, can this PR be merged or is there more work needed? |
|
@XAMPPRocky the actual goal of the wasmparser was to be used in no_std environment, e.g. use no memory allocations. It might be a good idea keep supporting this feature, and remove/configure/pref anything that needs allocations. |
|
@yurydelendik I don't have any particular preference one way or the other on the actual change itself, though I find the reasons for the changes mentioned in bytecodealliance/wasmtime#554 reasonable. It's more that I would be hesitant about making larger PRs with this PR still open since it could likely cause merge conflicts on one side or the other. |
|
Oops yes, sorry, this should be good to go now. |
yurydelendik
left a comment
yurydelendik
left a comment
There was a problem hiding this comment.
@alexcrichton can you remove test-no_std.sh as well?
This commit performs a similar transformation as bytecodealliance/wasmtime#554, with similar motivation listed out there as well.
6ad124d to
90e2641
Compare
|
Sure thing, done! |
|
Thank you |
3 participants
This commit performs a similar transformation as
bytecodealliance/wasmtime#554, with similar motivation listed out there
as well.