Fix validation panic with unreachable code#926
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Feb 11, 2023
Merged
Fix validation panic with unreachable code#926alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
This fixes a fuzz-found regression from bytecodealliance#701 where unreachable code could end up triggering a panic during validation.
Collaborator
|
Would it be possible (not inconvenient) if we could backport this fix to version |
Member
Author
|
#701 wasn't included in 0.100.0, so I don't believe it's affected. |
Collaborator
Ah perfect! Sorry then for my confused oversight. |
peterhuene
approved these changes
Feb 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a fuzz-found regression from #701 where unreachable code could end up triggering a panic during validation.