feat(wit-parser): allow the non-first segments of the kebab name to start with a number.#2355
Merged
alexcrichton merged 5 commits intobytecodealliance:mainfrom Oct 20, 2025
Merged
Conversation
chenyan2002
requested review from
alexcrichton
and removed request for
a team
Member
|
Thanks! In working on WebAssembly/component-model#345 one thing I want to consider though is the roadmap for how it's going to be implemented. For example I think it would best to avoid situations where half the system works and half the system doesn't due to the order in which things were done. Do you have an idea of how much of he rest of wasm-tools/wasmtime/etc need to be updated for this change? I would naively expect that wasmparser validation might need changing as well but not much else other than that. I wanted to see if you had plans already made though perhaps. |
Contributor
Author
|
I think that's all we needed. I tried locally with my wit file. Both |
alexcrichton
approved these changes
Oct 20, 2025
This was referenced Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially address WebAssembly/component-model#345.
Allow the non-first segments of the kebab name to start with a number.