Handle Duration overflow gracefully in kevent.#1427
Merged
Conversation
Add a `kevent_timespec` function, which is similar to `kevent`, but which takes a `Timespec` rather than a `Duration`, so that it can behave consistently with the other functions in `rustix::event`. This also more closely reflects how the underlying `kevent` function takes a `timespec` argument. And, change the existing `kevent` to treat overflow in its `Duration` argument by saturating to an effectively infinite timeout. This supports users that use `Duration::MAX` to indicate an effectively infinite timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
kevent_timespecfunction, which is similar tokevent, but which takes aTimespecrather than aDuration, so that it can behave consistently with the other functions inrustix::event. This also more closely reflects how the underlyingkeventfunction takes atimespecargument.And, change the existing
keventto treat overflow in itsDurationargument by saturating to an effectively infinite timeout. This supports users that useDuration::MAXto indicate an effectively infinite timeout.