Use NtCreateFile to implement open_unchecked on Windows.#293
Merged
sunfishcode merged 1 commit intomainfrom Feb 10, 2023
Merged
Use NtCreateFile to implement open_unchecked on Windows.#293sunfishcode merged 1 commit intomainfrom
NtCreateFile to implement open_unchecked on Windows.#293sunfishcode merged 1 commit intomainfrom
Conversation
sunfishcode
force-pushed
the
sunfishcode/nt-create-file-at-w
branch
from
aed0035 to
b2445aa
Compare
Windows' `NtCreateFile` has an ability to take a directory and a relative path, so use that to implement `open_unchecked` instead of using path concatenation. We still use concatenation for other functions, but this is the first step to rewriting those to avoid it. Fixes #226.
sunfishcode
force-pushed
the
sunfishcode/nt-create-file-at-w
branch
from
b5f68ba to
729cf34
Compare
sunfishcode
added a commit
that referenced
this pull request
Mar 16, 2023
Windows' `NtCreateFile` has an ability to take a directory and a relative path, so use that to implement `open_unchecked` instead of using path concatenation. We still use concatenation for other functions, but this is the first step to rewriting those to avoid it. Fixes #226.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows'
NtCreateFilehas an ability to take a directory and a relative path, so use that to implementopen_uncheckedinstead of using path concatenation.We still use concatenation for other functions, but this is the first step to rewriting those to avoid it.
Fixes #226.