Conversation
This change may break some C++ examples if their output is larger than 128 cols or rows. The limit is extended to 2048 cols and 1024 rows using the optimized termscraper's Screen. The runner also delegates to the parent class the output processing forcing the echo filtering with _is_echo_filtering_enforced() in True
…ge it (128x128 min) (API change) C++ runner not longer impose a fixed geometry of 128x128. This is changed to a default of 2048x1024 and it can be changed from command line and per example to any value with a minimum of 128x128. This may break some C++ examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.