Warn if a tab is present in the example's code (disable it with -warn…#244
Merged
Warn if a tab is present in the example's code (disable it with -warn…#244
Conversation
…-tab) (may break) When there is a tab character in the example's code, emit a warning. These tab characters may interfere with the interpreter/runner because some of them execute an UI action (like autocomplete) on a tab key stroke. byexample configured its runners to not do such UI action however it is not entirely possibly to dismiss the issue and because "if" it happens, it is really hard to understand and debug it, it is better to warn about it preventively. This "may break" backward compatibility because it may annoy the user. If needed, the user can set -warn-tab to disable the warning. It is not expected to break real code as using a tab in the example's code is unlikely and most probably a mistake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…-tab) (may break)
When there is a tab character in the example's code, emit a warning.
These tab characters may interfere with the interpreter/runner because
some of them execute an UI action (like autocomplete) on a tab key
stroke.
byexample configured its runners to not do such UI action however it is
not entirely possibly to dismiss the issue and because "if" it happens,
it is really hard to understand and debug it, it is better to warn about
it preventively.
This "may break" backward compatibility because it may annoy the user.
If needed, the user can set -warn-tab to disable the warning.
It is not expected to break real code as using a tab in the example's
code is unlikely and most probably a mistake.
Closes #193