You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit f8f984e
Browse filesBrowse the repository at this point in the historyBrowse files
fix: cite the open opencode issue and add the shell permission key (#149)
## What changes
- The OpenCode reviewer agent, `.opencode/agents/fresh-eyes-reviewer.md`
in every generated repository, now denies `shell` beside `bash`.
OpenCode v1.19.3, the current npm release, keeps `bash` as the shell
tool's permission key and says it will be renamed
(`packages/opencode/src/tool/shell/id.ts` at `v1.19.3`), and accepts and
ignores a `shell` key. The [permissions
page](https://opencode.ai/docs/permissions/) for this agent format names
only `shell`, and OpenCode V2 reads this format and maps its `bash` to
V2's `shell` action ([Migrate from
V1](https://dev.opencode.ai/v2/docs/migrate-v1/)). Under either key name
the reviewer has no shell. All checked 2026-10-22.
- The `fresh-eyes-review` skill and the README cite [OpenCode issue
49723](anomalyco/opencode#49723), which is
open, instead of 50627, which was closed on 2026-10-20 as its duplicate
(read 2026-10-22). The advice is unchanged: run the OpenCode reviewer
with another model than OpenCode's free tier.
- The README says that OpenCode also scans `.claude/skills`, so it logs
a `duplicate skill name` warning for each mirrored skill, and that the
path it lists in its system prompt can differ between sessions and cost
a prompt cache miss (`skill/index.ts` and `session/system.ts` at
`v1.19.3`).
- `validate_templates.py` pins the new frontmatter line and requires
`permission.shell: deny`, with two new self-test fixtures.
- The reviewer also sets `external_directory: ask`. OpenCode V2 allows
reads outside the project by default where V1 asks ([Migrate from
V1](https://dev.opencode.ai/v2/docs/migrate-v1/), checked 2026-10-22),
so on V2 its read tools would read outside the project unasked, against
what its instructions and the README say. On V1 the agent's rule comes
after OpenCode's defaults and the user's configuration, so the reviewer
now also asks for directories those allow, such as OpenCode's temporary
directory (except its tool output directory); the README and the upgrade
note say so (`agent/agent.ts` and `permission/index.ts` at `v1.19.3`).
The validator requires the value, with two more fixtures: 228 in all.
Found while answering the Codex threads (finding A-38); added at the
maintainer's decision.
- README: a new `### Upgrading to 0.17.1` section says both files are
template-owned, so `--check` reports them `stale` and `--adopt` updates
them.
This repository's own copies were regenerated with `./bootstrap.py
--adopt . --type simple --non-interactive`, committing only those two
agent files.
## User-visible
User-visible: yes
## Why
Findings A-30 and A-32 of the 2026-10-21 assessment, row 3.2 of its
plan. Without the `shell` key, the reviewer would get a shell on an
OpenCode release that has made the rename, whose shell rules cannot
reliably stop a redirect.
## How it was checked
On Linux with Python 3.13.16, Node 22.22.0 and a full clone, so
tag-dependent tests ran:
- `uv run --with pyyaml python3 validate_templates.py`: OK, 19
configurations, 228 fixtures.
- `uv run --with pytest --with pyyaml python3 -m pytest -q -p
no:cacheprovider`: 352 passed, 18 skipped, all of them root skips of the
permission tests and one case-insensitive filesystem test.
- `node --test templates/*.test.mjs`: 73 pass. `templates/*.mjs` is
unchanged, so Prettier and ESLint were not needed.
- Rendered Markdown lint on 316 files and repository Markdown lint on 17
files with `[email protected]`: 0 issues.
- A `nextjs` repository rendered from `main` at `761f2f7`: this branch's
`--check` reports both files `stale`, and `--adopt` updates them; the
reviewer then has `shell: deny`.
- No em or en dash on any added line.
- Not run: OpenCode itself, on 1.19.3 or V2.
Reviews: a fresh-eyes review by a separate Claude agent found no
blocking findings; its P3 (the `check_reviewer_agents` docstring) and
its note on the 2.0 wording are fixed in `b32d581`. Two Codex threads
are answered and resolved: the duplicate-skill cost holds and is fixed
in `6960681`; the permissions-page claim does not reproduce, and its V2
point is cited in `6960681`. The `external_directory` commit, `37af2e0`,
passed the same checks (pytest 352 passed, 18 skipped; both Markdown
lints 0 issues). A follow-up review (R2) found no blocking findings; its
P2 on the V1 wording is fixed in `6b051e6`.
## Checklist
- [x] The title is a Conventional Commit subject, and the pull request
makes one change
- [x] Every commit is signed off (`git commit -s`; see CONTRIBUTING.md)
- [x] Tests and docs are updated for the changed behaviour
fix: make the opencode reviewer ask before reading outside the project
---
*Prepared with the assistance of Claude Code (Claude Opus 5.5).*
---------
Signed-off-by: Claude <[email protected]>
Co-authored-by: Claude <[email protected]>
Copy file name to clipboardExpand all lines: .agents/skills/fresh-eyes-review/SKILL.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -3,7 +3,7 @@ name: fresh-eyes-review
3
3
description: >-
4
4
Use before declaring substantial work complete or a branch or pull request ready for review, after review fixes cause material changes, or when handling the findings of any review. Covers who reviews, what to hand the reviewer, how to verify, fix or dispute findings, when to review and re-review, and a cross-family recipe using a read-only reviewer from another model family. The reviewer follows `review-guidelines`.
Load the `review-guidelines` skill (`.agents/skills/review-guidelines/SKILL.md`) and follow it; if the change under review edits that file, ask for the base branch's copy and follow that, or the head copy when the base branch has none. You have no shell: review the diff, its base and head commits, and the validation results the implementer or person gives you or saved for you, and for a follow-up review the last report and the commits since; if you were not given the diff, ask for it before reviewing. Read files with the read tools, which ask the user before reading most paths outside the project, such as a scratch directory. Do not modify files. Report in the skill's format, with file:line evidence.
Copy file name to clipboardExpand all lines: templates/agents/opencode-fresh-eyes-reviewer.md
+2Lines changed: 2 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -5,6 +5,8 @@ permission:
5
5
edit: deny
6
6
task: deny
7
7
bash: deny
8
+
shell: deny
9
+
external_directory: ask
8
10
---
9
11
10
12
Load the `review-guidelines` skill (`.agents/skills/review-guidelines/SKILL.md`) and follow it; if the change under review edits that file, ask for the base branch's copy and follow that, or the head copy when the base branch has none. You have no shell: review the diff, its base and head commits, and the validation results the implementer or person gives you or saved for you, and for a follow-up review the last report and the commits since; if you were not given the diff, ask for it before reviewing. Read files with the read tools, which ask the user before reading most paths outside the project, such as a scratch directory. Do not modify files. Report in the skill's format, with file:line evidence.
0 commit comments