Repository navigation
Commit f288bed
committed
Restore cmd.exe wrapping for mklink and dir on Windows
`mklink` and `dir` are cmd.exe built-ins with no standalone executable,
so removing the cmd.exe wrapper for all Subprocess calls broke
FileUtils.symlink (and left FileUtils.symlink?/readlink working only
by accident, since `dir` happens to be on MRI's hardcoded list of
legacy cmd.exe built-ins that Process.spawn falls back to).
Unlike the removed general-purpose wrapper, this passes cmd.exe, /c,
and the command as separate argv elements rather than joining them
into one pre-escaped string, so it doesn't reintroduce the argument
corruption from sds#847.1 parent 9532ca1 commit f288bed
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| |||
0 commit comments