refactor: remove updatedWithError class instance property
#98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
approved these changes
Oct 29, 2021
Collaborator
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
Gave this a lot of thought and I think it's safe to merge and release as a non-breaking change. Hopefully the tests and I are not wrong 😅
Collaborator
|
Thank you! |
|
🎉 This PR is included in version 3.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
thanks! 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: removed the
updatedWithErrorclass instance property, and replaced with checkingprevState.errorincomponentDidUpdate.Why: i have found the
this.updatedWithErrora bit confusing to follow, and afaict checkingprevState.errorwlil do the same since we only want to avoid resetting the error state in the same render cycle where we received the error. tests are still passing, but feel free to close if you think this doesn't add anything.How:
Checklist:
also added eslint comment to disable sorting typescript union members, to keep the diff clear