Skip to content

refactor(types.ts): remove unnecessary declare function FallbackRender#204

Merged
bvaughn merged 1 commit intobvaughn:masterfrom
sukvvon:refactor/remove-delcare-function
Oct 28, 2024
Merged

refactor(types.ts): remove unnecessary declare function FallbackRender#204
bvaughn merged 1 commit intobvaughn:masterfrom
sukvvon:refactor/remove-delcare-function

Conversation

@sukvvon
Copy link
Copy Markdown
Contributor

@sukvvon sukvvon commented Oct 28, 2024

What:

  • remove unnecessay declare function FallbackRender

Why:

  • declare is only necessary for external modules or global scope.
    • using declare for internally used functions or types is unnecessary.
    • if the function is not provided externally, it is clearer to define it explicitly.
  • improved code consistency and readability.
    • by removing unnecessary declare keywords, the code becomes more concise and maintains a consistent structure.
    • directly defining function types reduces confusion between implementation and declaration.

How:

  • ensuring consistency between types and implementation.
    • by removing declare and managing type definitions alongside implementations, it prevents inconsistencies between types and actual behavior.
    • code changes ensure that type definitions and implementations are updated together, enhancing maintainability.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@bvaughn bvaughn merged commit 0a10d4c into bvaughn:master Oct 28, 2024
@sukvvon sukvvon deleted the refactor/remove-delcare-function branch October 28, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants