-
Notifications
You must be signed in to change notification settings - Fork 39
overriding my date configuration #9
Copy link
Copy link
Closed
Description
I just noticed that when I have am using your package to benchmark, my timezone is overwritten
By default I have it set to Singapore
in my config/app.php
I have
'timezone' => 'Asia/Singapore',
I was running benchmarking on aggregate queries that use the dates and I was noticing that my graphs were off and different from my production data even though I am using the same database data
I think it's because of this line:
private function setDefaultTimeZone()
{
// Check date function
if( ! ini_get('date.timezone'))
date_default_timezone_set('UTC');
}
In your ConfigHandler.php
Is this really necessary ? Shouldn't your benchmarking work regardless of what timezone is set?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels