Fix usb_everdrive_poll for compilers using signed char#113
Merged
buu342 merged 1 commit intobuu342:masterfrom Jun 15, 2023
Merged
Fix usb_everdrive_poll for compilers using signed char#113buu342 merged 1 commit intobuu342:masterfrom
usb_everdrive_poll for compilers using signed char#113buu342 merged 1 commit intobuu342:masterfrom
Conversation
Owner
|
Thank you for the PR + bug fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
usb_everdrive_pollso that it will always compute the correct packet size on compilers where the default signedness ofcharis signed, as is the case in the libdragon toolchain. See #112 for more specifics on why this doesn't work as-is.Related Issue
#112
Motivation and Context
Sending packets of specific sizes over Everdrive USB to programs built with a compiler where
chardefaults to signed currently does not work. I ran into this while working on a project involving doing just that.How Has This Been Tested?
Previously, a packet of length 0x80 - 0xFF (inclusive) would appear to never arrive. After this change such packets arrive as expected.
Screenshots (if appropriate):