Skip to content

Commit 7fa82d6

Browse files
feat(settings): wire persistent language selection (anomalyco#728)
1 parent cad9488 commit 7fa82d6

4 files changed

Lines changed: 40 additions & 1 deletion

File tree

‎packages/app/src/app/pages/dashboard.tsx‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ import {
7070
SlidersHorizontal,
7171
Zap,
7272
} from "lucide-solid";
73+
import type { Language } from "../../i18n";
7374

7475
export type DashboardViewProps = {
7576
tab: DashboardTab;
@@ -243,6 +244,8 @@ export type DashboardViewProps = {
243244
toggleHideTitlebar: () => void;
244245
modelVariantLabel: string;
245246
editModelVariant: () => void;
247+
language: Language;
248+
setLanguage: (value: Language) => void;
246249
updateAutoCheck: boolean;
247250
toggleUpdateAutoCheck: () => void;
248251
updateAutoDownload: boolean;
@@ -1336,6 +1339,8 @@ export default function DashboardView(props: DashboardViewProps) {
13361339
toggleHideTitlebar={props.toggleHideTitlebar}
13371340
modelVariantLabel={props.modelVariantLabel}
13381341
editModelVariant={props.editModelVariant}
1342+
language={props.language}
1343+
setLanguage={props.setLanguage}
13391344
updateAutoCheck={props.updateAutoCheck}
13401345
toggleUpdateAutoCheck={props.toggleUpdateAutoCheck}
13411346
updateAutoDownload={props.updateAutoDownload}

‎packages/app/src/app/pages/settings.tsx‎

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import {
2828
openworkServerRestart,
2929
pickFile,
3030
} from "../lib/tauri";
31-
import { currentLocale, t } from "../../i18n";
31+
import { currentLocale, LANGUAGE_OPTIONS, t, type Language } from "../../i18n";
3232

3333
export type SettingsViewProps = {
3434
startupPreference: StartupPreference | null;
@@ -78,6 +78,8 @@ export type SettingsViewProps = {
7878
toggleHideTitlebar: () => void;
7979
modelVariantLabel: string;
8080
editModelVariant: () => void;
81+
language: Language;
82+
setLanguage: (value: Language) => void;
8183
themeMode: "light" | "dark" | "system";
8284
setThemeMode: (value: "light" | "dark" | "system") => void;
8385
updateAutoCheck: boolean;
@@ -843,6 +845,25 @@ export default function SettingsView(props: SettingsViewProps) {
843845
</Button>
844846
</div>
845847

848+
<div class="space-y-2">
849+
<div class="text-xs font-medium text-gray-11">{translate("settings.language")}</div>
850+
<div class="text-xs text-gray-9">{translate("settings.language.description")}</div>
851+
<div class="flex flex-wrap gap-2">
852+
<For each={LANGUAGE_OPTIONS}>
853+
{(option) => (
854+
<Button
855+
variant={props.language === option.value ? "secondary" : "outline"}
856+
class="text-xs h-8 py-0 px-3"
857+
onClick={() => props.setLanguage(option.value)}
858+
disabled={props.busy}
859+
>
860+
{option.nativeName}
861+
</Button>
862+
)}
863+
</For>
864+
</div>
865+
</div>
866+
846867
<div class="text-xs text-gray-8">
847868
System mode follows your OS preference automatically.
848869
</div>

‎packages/app/src/i18n/index.ts‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,10 @@ export const setLocale = (newLocale: Language) => {
5959

6060
setLocaleSignal(newLocale);
6161

62+
if (typeof document !== "undefined") {
63+
document.documentElement.setAttribute("lang", newLocale);
64+
}
65+
6266
// Persist to localStorage
6367
if (typeof window !== "undefined") {
6468
try {
@@ -107,11 +111,18 @@ export const initLocale = (): Language => {
107111
const stored = window.localStorage.getItem(LANGUAGE_PREF_KEY);
108112
if (isLanguage(stored)) {
109113
setLocaleSignal(stored);
114+
if (typeof document !== "undefined") {
115+
document.documentElement.setAttribute("lang", stored);
116+
}
110117
return stored;
111118
}
112119
} catch (e) {
113120
console.warn("Failed to read language preference:", e);
114121
}
115122

123+
if (typeof document !== "undefined") {
124+
document.documentElement.setAttribute("lang", "en");
125+
}
126+
116127
return "en";
117128
};

‎packages/app/src/index.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,10 @@ import "./app/index.css";
77
import AppEntry from "./app/entry";
88
import { PlatformProvider, type Platform } from "./app/context/platform";
99
import { isTauriRuntime } from "./app/utils";
10+
import { initLocale } from "./i18n";
1011

1112
bootstrapTheme();
13+
initLocale();
1214

1315
const root = document.getElementById("root");
1416

0 commit comments

Comments
 (0)