Skip to content

Commit 3fe86db

Browse files
authored
fix(session): stabilize step timeline scrolling (anomalyco#1662)
Co-authored-by: src-opn <[email protected]>
1 parent b4f166c commit 3fe86db

1 file changed

Lines changed: 2 additions & 7 deletions

File tree

‎apps/app/src/react-app/domains/session/surface/message-list.tsx‎

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -644,7 +644,6 @@ function StepsContainer(props: {
644644
isUser: boolean;
645645
isInline?: boolean;
646646
isNestedVariant: boolean;
647-
isStreaming: boolean;
648647
expandedStepIds: Set<string>;
649648
onExpandedStepIdsChange: (updater: (current: Set<string>) => Set<string>) => void;
650649
}) {
@@ -660,14 +659,12 @@ function StepsContainer(props: {
660659
});
661660
};
662661

663-
const useInnerTimelineScroll = !props.isStreaming;
664-
665662
return (
666663
<div className={props.isInline ? (props.isUser ? "mt-3" : "mt-4") : ""}>
667664
<div
668-
data-scrollable={useInnerTimelineScroll && !props.isNestedVariant ? "true" : undefined}
665+
data-scrollable={!props.isNestedVariant ? "true" : undefined}
669666
className={
670-
!props.isNestedVariant && useInnerTimelineScroll
667+
!props.isNestedVariant
671668
? "max-h-[420px] overflow-y-auto pr-3"
672669
: ""
673670
}
@@ -956,7 +953,6 @@ function SessionTranscriptInner(props: SessionTranscriptProps) {
956953
stepGroups={block.stepGroups}
957954
isUser={block.isUser}
958955
isNestedVariant={isNestedVariant}
959-
isStreaming={props.isStreaming}
960956
expandedStepIds={expandedStepIds}
961957
onExpandedStepIdsChange={onExpandedStepIdsChange}
962958
/>
@@ -1089,7 +1085,6 @@ function SessionTranscriptInner(props: SessionTranscriptProps) {
10891085
isUser={block.isUser}
10901086
isInline={true}
10911087
isNestedVariant={isNestedVariant}
1092-
isStreaming={props.isStreaming}
10931088
expandedStepIds={expandedStepIds}
10941089
onExpandedStepIdsChange={onExpandedStepIdsChange}
10951090
/>

0 commit comments

Comments
 (0)