Skip to content

Commit 307c8bc

Browse files
authored
feat(den): let users name their LLM providers explicitly (anomalyco#1508)
Users were confused when adding or editing an LLM provider because the display name was derived automatically from the catalog or pasted config. This made it impossible to tell two keys for the same provider apart (e.g. 'OpenAI personal' vs 'OpenAI prod'). - Add an explicit 'Name' field to the add + edit LLM provider forms in ee/apps/den-web with a 'Give this key a name' prompt, preload the current name when editing, and require a non-empty value before save. - Require 'name' on the llm-provider write schema in ee/apps/den-api and persist it verbatim instead of falling back to provider.name from the models.dev catalog or the custom config JSON. Verified end-to-end via Chrome DevTools MCP on the Den Docker stack; screenshots captured under ee/apps/den-web/docs/screenshots/. Co-authored-by: src-opn <[email protected]>
1 parent 609a57f commit 307c8bc

8 files changed

Lines changed: 31 additions & 3 deletions

File tree

‎ee/apps/den-api/src/routes/org/llm-providers.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ const customProviderSchema = z.object({
6060
}).passthrough()
6161

6262
const llmProviderWriteSchema = z.object({
63+
name: z.string().trim().min(1).max(255),
6364
source: z.enum(["models_dev", "custom"]),
6465
providerId: z.string().trim().min(1).max(255).optional(),
6566
modelIds: z.array(z.string().trim().min(1).max(255)).min(1).optional(),
@@ -288,7 +289,7 @@ async function normalizeLlmProviderInput(input: z.infer<typeof llmProviderWriteS
288289
return {
289290
source: input.source,
290291
providerId: provider.id,
291-
name: provider.name,
292+
name: input.name,
292293
providerConfig: provider.config,
293294
models: models.map((model) => ({
294295
id: model.id,
@@ -320,7 +321,7 @@ async function normalizeLlmProviderInput(input: z.infer<typeof llmProviderWriteS
320321
return {
321322
source: input.source,
322323
providerId: customProvider.data.id,
323-
name: customProvider.data.name,
324+
name: input.name,
324325
providerConfig: providerConfig as JsonRecord,
325326
models: models.map((model) => ({
326327
id: model.id,

‎ee/apps/den-web/app/(den)/o/[orgSlug]/dashboard/_components/llm-provider-editor-screen.tsx‎

Lines changed: 28 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ export function LlmProviderEditorScreen({
8181
useState<DenModelsDevProviderDetail | null>(null);
8282
const [detailBusy, setDetailBusy] = useState(false);
8383
const [detailError, setDetailError] = useState<string | null>(null);
84+
const [providerName, setProviderName] = useState("");
8485
const [selectedModelIds, setSelectedModelIds] = useState<string[]>([]);
8586
const [modelQuery, setModelQuery] = useState("");
8687
const [customConfigText, setCustomConfigText] = useState(
@@ -131,6 +132,7 @@ export function LlmProviderEditorScreen({
131132
if (provider) {
132133
setSource(provider.source);
133134
setSelectedProviderId(provider.providerId);
135+
setProviderName(provider.name);
134136
setSelectedModelIds(provider.models.map((entry) => entry.id));
135137
setSelectedMemberIds(
136138
provider.access.members.map((entry) => entry.orgMembershipId),
@@ -149,6 +151,7 @@ export function LlmProviderEditorScreen({
149151

150152
setSource("models_dev");
151153
setSelectedProviderId("");
154+
setProviderName("");
152155
setSelectedModelIds([]);
153156
setSelectedMemberIds(
154157
orgContext?.currentMember.id ? [orgContext.currentMember.id] : [],
@@ -261,6 +264,11 @@ export function LlmProviderEditorScreen({
261264
return;
262265
}
263266

267+
if (!providerName.trim()) {
268+
setSaveError("Give this provider a name.");
269+
return;
270+
}
271+
264272
if (source === "models_dev") {
265273
if (!selectedProviderId) {
266274
setSaveError("Select a provider.");
@@ -281,6 +289,7 @@ export function LlmProviderEditorScreen({
281289
setSaveError(null);
282290
try {
283291
const body: Record<string, unknown> = {
292+
name: providerName.trim(),
284293
source,
285294
memberIds: [...new Set(selectedMemberIds)],
286295
teamIds: [...new Set(selectedTeamIds)],
@@ -396,7 +405,7 @@ export function LlmProviderEditorScreen({
396405
<div>
397406
<h1 className="text-[34px] font-semibold tracking-[-0.07em] text-gray-950">
398407
{provider
399-
? provider.name
408+
? (providerName.trim() || provider.name)
400409
: "Add a new LLM provider"}
401410
</h1>
402411
<p className="mt-3 max-w-[720px] text-[16px] leading-8 text-gray-500">
@@ -435,6 +444,24 @@ export function LlmProviderEditorScreen({
435444
</div>
436445
) : null}
437446

447+
<section className="mb-8 rounded-[36px] border border-gray-200 bg-white p-8 shadow-[0_18px_48px_-34px_rgba(15,23,42,0.24)]">
448+
<label className="grid gap-3">
449+
<span className="text-[14px] font-medium text-gray-700">
450+
Name
451+
</span>
452+
<DenInput
453+
value={providerName}
454+
onChange={(event) => setProviderName(event.target.value)}
455+
placeholder="Give this key a name"
456+
autoComplete="off"
457+
/>
458+
</label>
459+
<p className="mt-3 text-[13px] text-gray-500">
460+
Pick a clear label so teammates know which key or provider
461+
setup they are using.
462+
</p>
463+
</section>
464+
438465
<section className="mb-8 rounded-[36px] border border-gray-200 bg-white p-8 shadow-[0_18px_48px_-34px_rgba(15,23,42,0.24)]">
439466
<h2 className="mb-6 text-[24px] font-semibold tracking-[-0.05em] text-gray-950">
440467
Provider type
150 KB
Loading
150 KB
Loading
447 KB
Loading
174 KB
Loading
447 KB
Loading
199 KB
Loading

0 commit comments

Comments
 (0)