fix garble with newer Go tip versions#601
Merged
mvdan merged 1 commit intoburrowers:masterfrom Nov 12, 2022
Merged
Conversation
Member
Author
|
Hm, I broke reproducibility of the runtime, somehow. |
Some big changes landed in Go for the upcoming 1.20. While here, remove the use of GOGC=off with make.bash, as https://go.dev/cl/436235 makes that unnecessary now.
Member
Author
|
Should be ready now. That mac failure might have been a bug in the slightly older Go tip on Mac. I spent half a day trying to reproduce on Linux but got nothing, and I re-reviewed the changes in this PR, so I'm fairly sure there is no new bug in garble. |
capnspacehook
approved these changes
Nov 12, 2022
Contributor
|
Hmm not letting me merge on the mobile app for some reason |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(see commit message)