Skip to content

Commit a66c898

Browse files
AdamGSJefffrey
andauthored
ci: Setup valid Cargo.lock for depcheck to unblock CI (apache#22933)
## Which issue does this PR close? - Closes apache#22932 ## Rationale for this change `depcheck` stopped working because an underlying dependency released a non-semver compatible change (`time 0.3.48`, not going to link to the issue there because people are already spamming it). Because there was no lockfile, every run pulled the most recent versions for all dependencies, which don't currently compile. ## What changes are included in this PR? 1. Add lockfile to `depcheck` 2. Make sure to run `depcheck` with `--lock` in CI ## Are these changes tested? Tested locally ## Are there any user-facing changes? None Co-authored-by: Jeffrey Vo <[email protected]>
1 parent 49b99bb commit a66c898

3 files changed

Lines changed: 4169 additions & 3 deletions

File tree

‎.github/workflows/dependencies.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ jobs:
5050
with:
5151
rust-version: stable
5252
- name: Check dependencies
53+
working-directory: dev/depcheck
5354
run: |
54-
cd dev/depcheck
55-
cargo run
55+
cargo run --locked
5656
5757
detect-unused-dependencies:
5858
name: Detect Unused Dependencies

‎dev/depcheck/.gitignore‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)