Skip to content

Commit 0fcaef3

Browse files
authored
chore: extend pre commit instructions for AI agents (apache#23313)
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes apache#22455 . ## Rationale for this change Extend pre commit instructions for AI agents to involve contributor machine to find issues before being committed. Each commit triggers a CI which in its turn asks ASF Infra for their precious resources and if we can find and fix as early as possible, much before utilizing ASF resources, would be amazing <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
1 parent 01c7527 commit 0fcaef3

1 file changed

Lines changed: 14 additions & 2 deletions

File tree

‎AGENTS.md‎

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,20 @@ When creating a PR, you MUST follow the [PR template](.github/pull_request_templ
3737

3838
## Testing
3939

40-
See the [Testing Quick Start](docs/source/contributor-guide/testing.md#testing-quick-start)
41-
for the recommended pre-PR test commands.
40+
If documentation files changed then run
41+
```bash
42+
./ci/scripts/doc_prettier_check.sh --write --allow-dirty
43+
```
44+
45+
Otherwise, run extended tests
46+
```bash
47+
RUST_BACKTRACE=1 cargo test --profile ci \
48+
--exclude datafusion-examples --exclude datafusion-benchmarks --exclude datafusion-cli \
49+
--workspace --lib --tests --bins \
50+
--features avro,json,backtrace,extended_tests,recursive_protection,parquet_encryption
51+
```
52+
53+
For modified code identify local benchmarks(if any) and run them against `main`. See [Benchmarks](benchmarks/README.md).
4254

4355
## Agent Skills
4456

0 commit comments

Comments
 (0)