Clean up preserveGainmapAndColorSpaceForTransformations flag#5366
Merged
kanelbulle merged 1 commit intobumptech:masterfrom Feb 13, 2024
Merged
Clean up preserveGainmapAndColorSpaceForTransformations flag#5366kanelbulle merged 1 commit intobumptech:masterfrom
kanelbulle merged 1 commit intobumptech:masterfrom
Conversation
Collaborator
Author
|
Clean up for #5333 |
kanelbulle
approved these changes
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is almost a pure clean-up, with only one notable difference.
The new code path changed the behavior of rotateImageExif, which in the old path forced a non-null config of ARGB_8888 for bitmaps with null configs. In order to reuse bitmaps using
Bitmap.reconfigure, a non-null config is required (see #194). A null config can be due to a non-public bitmap type as documented in that issue.The new flow removes the need to reconfigure a bitmap, and thus should do a better job of preserving the config and not forcing it to ARGB_8888.
Thus, I had to change one unit test that tested this behavior being exercised in BitmapPool.