feat(i18n): Hebrew locale + full RTL support#492
Merged
Conversation
Contributor
Author
|
Member
|
please fix the merge commits, will merge then |
shukiv
force-pushed
the
feat/hebrew-locale-rtl
branch
from
July 7, 2026 22:01
4c14c68 to
4bfd78d
Compare
Contributor
Author
|
Done — rebased onto latest |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Hebrew (he) as a fully-translated right-to-left locale, the RTL infrastructure the app was missing, an Auto language mode, and Gmail-style RTL compose editing.
Included
Hebrew locale — full
locales/he/common.jsonat parity withen(0 missing/0 extra, passes translation tests);hewired through routing, request loader, client message map, and the language switcher (+ Israel flag).RTL support (app was LTR-only) —
diron<html>(server) + client effect on switch;i18n/direction.tscoversheandfa(Persian was an upstream locale rendered LTR). Physical→logical Tailwind sweep across ~100 files (ml/mr/pl/pr→ms/me/ps/pe,text-left/right→text-start/end,border-l/r→border-s/e, key absolute offsets). Mirror directional lucide icons underdir=rtl. Component fixes: toggle-knob direction, language-dropdown width/anchor, email-row hover-actions side + fade, unread-dot.English fallback — server + client deep-merge
enas base under the active locale, so any untranslated key shows English instead of a raw message key (benefits every locale).Auto language — switcher gains an
Autooption (default): server detects browser viaAccept-Language, client resolves the same; explicit pick overrides.getEffectiveLocale()guardsIntl.*against theautosentinel.Compose RTL editing (Gmail-style) — a "Right-to-left editing support" toggle (default off); when on, a toolbar button sets per-paragraph direction via a small TipTap
TextDirectionextension;dirround-trips into sent HTML.Localized relative time —
formatDaterelative mode usesIntl.RelativeTimeFormat(natural grammar): "an hour ago" / "לפני שעה", "2 days ago" / "לפני יומיים".Testing
npm run typecheckpasses.hepasses the translation parity tests. The other failing locale tests are pre-existing on main (locales already missing keys, e.g.settings.advanced.sender_avatars.*) — untouched by this PR.Notes
left/rightpositioning cases outside the already-fixed row/nav may need per-case follow-up.