Repository navigation
feat(): next - #1336
Merged
Merged
feat(): next#1336
Conversation
-darken the opacity to improve readability -update text color of disabled chips to look non-selectable -remove the X icon to further confer that this chip is read-only Co-authored-by: Michael Dill <[email protected]>
* Expanding non-ideal-state for use case with novo-loading * Expanding non-ideal-state for use case with novo-loading * Minor structure cleanup * Changed message on example
…#1333) * feat(Description): add ability for control description to handle html * feat(Description) cleaning up example for description containing HTML * feat(Description) adding new example for new FieldInteractionAPI functionality * regeneratinv package-lock as v1 and fixing minor type Co-authored-by: Fayranne Lipton <[email protected]> Co-authored-by: John Sullivan <[email protected]> Co-authored-by: Dan Voegelin <[email protected]>
…ting queries (#1328) * Select is intercepting clicks to the ng-content area * adding circle icon shape * not closing overlay if clicking in nested overlay * add shape attr to color option as well * Set GlobalSearch on setInitialSortFilter * clear global search * feat(lib): SearchBox now has keepOpen flag * updating search box styling and functionality * updating search box styling * adding event emitter for applying search * add options for advanced filtering to getTableResults * advanced filtering on Interfaces an setInitialSortFilter * refactor(): some remaining prep work for the upcoming typescript 4 upgrade * adding value getters to some table cells * Revert "refactor(): "REVERT: some refactor work in preparation for typescript 4.0.8 upgrade (#1266)" (#1271)" This reverts commit 5be0308. * upping ts version to 4.0.8 * Revert "refactor(): "REVERT: some refactor work in preparation for typescript 4.0.8 upgrade (#1266)" (#1271)" This reverts commit 5be0308. * adding dep * update to angular 11 * updated typedoc to .22 * update to angular 12 * fixing typing issue caused by microsoft/TypeScript#35865 * addressing deprecation warnings * updating angular/cdk to 12.2.13 * angular 13 update * updating @angular/cdk to 13.3.1 * commented a lot of things out to get build to pass, will have to find fixes * upgrading to jest 27 * modifying schematics to get build to pass, may have broken some things * refactoring overlay components to use FlexibleConnectedPositionStrategy * updating compilation mode, disabling some tests, and re-enabling a lot more * removing console log * fixing dragula import * initial fix for cke mock * adding autoposition to extra large tooltip example * adding bounce * !: Upgrading to Angular 13 * chore(release): 7.0.0-next.0 * fix(Stepper): Remove circular reference caused by unused code * fix(DataTable): Removed circular dependencies * fix(Breadcrumb): No more circular deps fix(EntityPickerResults): No more circular deps * chore(release): 7.0.1-next.0 * fixing broken unit test * chore(release): 7.1.0-next.0 * fix for function not found error * chore(release): 7.1.1-next.0 * fixing bug with simple table component * formatting * chore(release): 7.1.2-next.0 * increasing toolstip offset to eliminate cursor juddering * enabling auto tooltip positioning by default * fix(NovoFileInputElement): Allow for same file delete/upload, allow file list clear from patchValue(). (#1300) * 1183 & 1184: Correct FileInput upload issues. * Code review fixes * Added clear file list button for testing * Updated novo-design-tokens version * Updgraded htmlhint to remove async security vulnerability Co-authored-by: Kurt Mcgallion <[email protected]> * chore(release): 7.2.0-next.0 * feat(QueryBuilder): Added a search criteria builder (#1302) * style(Chips): remove max-width from novo-picker if a row chips picker (#1299) * chore(release): 6.2.1 * feat(QueryBuilder): Added WIP Query Builder * fix(QueryBuilder): Removed to much unused code * fix(QB): minor tweeks to presentation and remove check on DataSpecialization * linting * reverting changes to select sizing because it made it too tall Co-authored-by: Michael Dill <[email protected]> Co-authored-by: Bump And Release <[email protected]> Co-authored-by: Dan Voegelin <[email protected]> * fix(imports): fix a few utils imports to correct issues with debugging locally (#1303) * chore(release): 7.2.1-next.0 * fix(Schematic): Missing schematics and documentation * chore(release): 7.2.2-next.0 * fix(import): fix a utils import to correct issues with debugging locally (#1305) * making 'or' configurable, adding default criteria row * adding configurable label for translating * field padding and red trash can * fixing input box padding * remove entity picker in field select * adjusting calendar icon spacing * removing unused files * Added fixes and styling updates for novo-accordion * adding mockup of boolean field def * BH-75889 - Use correct comparison for dates in time picker input (#1304) Co-authored-by: kristian.robe <[email protected]> * chore(release): 7.2.3-next.0 * updates to boolean def and adding dummy address def * wip: Got custom field defs working * refactor(QueryBuilder): Renamed all the tokens,directives and subclasses * some minor fixes for string def * adding Double field type * Fixed definition field label and date-between input * adding/removing default picker defs * temporary workaround for scalar field needing select def not picker * adding another def * fixing variable name * updating field def logic * updating some console logs * updating console log * fixing custom def in demo * chore(release): 7.2.4-next.0 * simplifying field def logic * adding label fallback to entity picker result name * adding display labels for BillingProfile and InvoiceTerm results * add optional backdrop input option to search component * Styling updates for selects and picker in query builder * Fix build issues * removing max-width from novo-search's input * Delete button fix, input value width fixes, individual chip deletion fix * BH-75391 : fix grouped multi picker list item width. (#1312) * style(picker): Added data-automation-id to picker results (#1317) * chore(release): 7.2.5-next.0 * Fixed text field persistence issue. * fixing some build issues that popped up from rebase * reverting changes to package-lock * updates to support where clauses * Removed comments, fixed date inoput example, clear date field on operator change. * Added picker overlay to trigger on input field * Fixed booleaninput import * Small style fix * adding ellipsis attribute and fixing text transitions * Fixed border style * update bullhorn icons version * Close date picker on select * fixing default search box input cont size * removed some unnecessary styling * adding ability to pre-populate and clear query builder form * Fix field name identifier * rebase * feat(CKEditor): Do not encode special characters by default (#1320) * chore(workflow): updating node version for release workflows * chore(workflow): updating NPM_TOKEN for release workflow * poackage-lock updates and fixing unit tests * fix for form prepopulation bug in the demo * temporarily reverting fieldName change and adding labels to prepopulated fields * fixing a few things * feat(QueryBuilder): Updated QueryBuilder styles, added ConditionGroups and service to support pre-population fix(Field): PickerToggle should support triggerOnFocus now. feat(Common): *New* Visible directive to control visiblity * updating where property from string to object * style(QueryBuilder): borders are now round * style(QueryBuilder): Labels now ash * linting * reverting fieldName change * Update field selection and clear value and operator on field change * re-enabling form prepopulation * updating date format for range picker to work with prepopulation * refactoring query builder to use NovoLabelService everywhere * ux and styling tweaks * Added automation id for add condition and bolded clear all * updating icon size attributes to better scale with base icon 1.2em font-size * hiding tooltip when parent overlay closes * removing obsolete advancedFilter properties and replacing some with where * fixing unit test * Fixed date overlay issue * making tooltip directive show/hide functions public * adding data-control-type to novo-field * adding prop to allow event propagation * trying out adding control id * adding highlight pipe and refactoring templates to use it * fixing bug with nested overlays closing on click events * feat(Autocomplete): Autocomplete now works with ChipList (#1326) * deprecating highlight fns * Updated Search Data * fix(Chips): update the ux for disabled chips (#1331) -darken the opacity to improve readability -update text color of disabled chips to look non-selectable -remove the X icon to further confer that this chip is read-only Co-authored-by: Michael Dill <[email protected]> * feat(NonIdealState): Non Ideal Loading (#1334) * Expanding non-ideal-state for use case with novo-loading * Expanding non-ideal-state for use case with novo-loading * Minor structure cleanup * Changed message on example * chore(ci): updating tokens * chore(ci): Other Tokens Updated * feat(Description): add ability for control description to handle html (#1333) * feat(Description): add ability for control description to handle html * feat(Description) cleaning up example for description containing HTML * feat(Description) adding new example for new FieldInteractionAPI functionality * regeneratinv package-lock as v1 and fixing minor type Co-authored-by: Fayranne Lipton <[email protected]> Co-authored-by: John Sullivan <[email protected]> Co-authored-by: Dan Voegelin <[email protected]> * feat(Docs): new docs, and bump release * fixing chiplist issue and clearing queryform operator/value on field change * feat(Bump): Needs a bump for semantic release * code review changes Co-authored-by: Michael Dill <[email protected]> Co-authored-by: Dan Voegelin <[email protected]> Co-authored-by: Haris Iqbal <[email protected]> Co-authored-by: Bump And Release <[email protected]> Co-authored-by: Kurt Mcgallion <[email protected]> Co-authored-by: Kurt Mcgallion <[email protected]> Co-authored-by: Kristian Robe <[email protected]> Co-authored-by: kristian.robe <[email protected]> Co-authored-by: Jordan Brownfield <[email protected]> Co-authored-by: kiri-um-bh <[email protected]> Co-authored-by: Kurt Mcgallion <[email protected]> Co-authored-by: antonyw89 <[email protected]> Co-authored-by: Michael Dill <[email protected]> Co-authored-by: Fayranne Lipton <[email protected]> Co-authored-by: Fayranne Lipton <[email protected]> Co-authored-by: John Sullivan <[email protected]>
Contributor
|
Visit the preview URL for this PR (updated for commit c0b1130): (expires Tue, 09 Aug 2022 19:26:55 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
ndickerson
reviewed
Aug 4, 2022
ndickerson
left a comment
Member
There was a problem hiding this comment.
Noted where there is commented out code. Not sure if this is known, and planned to fix later or not.
| this.unmask = false; | ||
| this.imask = { | ||
| mask: 'm{/}`d{/}`Y - m{/}`d{/}`Y', | ||
| // pattern: 'm{/}`d{/}`Y - m{/}`d{/}`Y', |
| _renderer: Renderer2, | ||
| _factory: IMaskFactory, | ||
| @Optional() @Inject(PLATFORM_ID) _platformId: string, | ||
| // @Optional() @Inject(PLATFORM_ID) _platformId: string, |
| <ng-content></ng-content> | ||
| </form> | ||
|
|
||
| <!-- EMPTY STATE TEMPLATE --> |
Member
There was a problem hiding this comment.
commented out code - do we need this or not?
| position: relative; | ||
| cursor: pointer; | ||
| margin: 0.4rem auto; | ||
| // vertical-align: middle; |
| const { fields = [] } = this.qbs.config || {}; | ||
| fields.length && this.changeFieldOptions(fields[0]); | ||
| this.searches = this.searchTerm.valueChanges.pipe(debounceTime(300), distinctUntilChanged()).subscribe((term) => { | ||
| // this.parentForm.get('field').setValue(null); |
| [this._operatorOutlet.viewContainer, this._inputOutlet.viewContainer].forEach((def) => { | ||
| def.clear(); | ||
| }); | ||
| // this._contentFieldTypeDefs = []; |
| * @param fieldConfig | ||
| */ | ||
| changeFieldOptions(fieldConfig: FieldConfig<BaseFieldDef>) { | ||
| // this.fields = entity.filter(term); |
| </novo-stack> | ||
|
|
||
|
|
||
| <!-- <button class="and-or-button" theme="secondary" size="sm" (click)="addRootCondition()">{{ addCriteriaLabel }}</button> --> |
| <novo-picker-condition-def name="SELECT"></novo-picker-condition-def> | ||
| <novo-string-condition-def name="DEFAULT"></novo-string-condition-def> | ||
|
|
||
| <!-- |
| endDate: '1922-01-17', | ||
| } | ||
| }, | ||
| // where=category IN (1,2,3) |
ccarbonellbh
reviewed
Aug 4, 2022
| // do nothing | ||
| } else if (this._chipInput) { | ||
| this._focusInput(options); | ||
| Promise.resolve().then(() => this._focusInput(options)); |
Collaborator
There was a problem hiding this comment.
What does this change give us here?
ccarbonellbh
reviewed
Aug 4, 2022
| _renderer: Renderer2, | ||
| _factory: IMaskFactory, | ||
| @Optional() @Inject(PLATFORM_ID) _platformId: string, | ||
| // @Optional() @Inject(PLATFORM_ID) _platformId: string, |
ccarbonellbh
reviewed
Aug 4, 2022
| _renderer: Renderer2, | ||
| _factory: IMaskFactory, | ||
| @Optional() @Inject(PLATFORM_ID) _platformId: string, | ||
| // @Optional() @Inject(PLATFORM_ID) _platformId: string, |
ccarbonellbh
reviewed
Aug 4, 2022
|
|
||
| /** | ||
| * Contruction filters against String fields can be complex. Each "chip" added to the | ||
| * condition can be used to indendantly used to query a database. Not all systems support |
ccarbonellbh
reviewed
Aug 4, 2022
| 📢 June 2022 (version 7.2.x) | ||
| =========================== | ||
|
|
||
| **New Feature: Query Builder**: We have added a new component to help with building complex and modern interfaces. At Bullhorn we have to enable our users to create advanced and dynamic searches against there data. We have built many iterations of a query builder in the past but we think this one is our best and most re-usable. |
Collaborator
There was a problem hiding this comment.
Suggested change
| **New Feature: Query Builder**: We have added a new component to help with building complex and modern interfaces. At Bullhorn we have to enable our users to create advanced and dynamic searches against there data. We have built many iterations of a query builder in the past but we think this one is our best and most re-usable. | |
| **New Feature: Query Builder**: We have added a new component to help with building complex and modern interfaces. At Bullhorn we have to enable our users to create advanced and dynamic searches against their data. We have built many iterations of a query builder in the past but we think this one is our best and most re-usable. |
ccarbonellbh
approved these changes
Aug 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
feat(QueryBuilder): New QueryBuilder component for dynamically generating queries #1328
Verify that...
npm startandnpm run buildstill worksSafari,ChromeandFirefoxnpm run lintpassesnpm testpasses and code coverage is increasednpm run buildstill worksBullhorn Internal Developers
Novo AutomationScreenshots