update logic for printing exception messages for invalid buildspecs#1340
Merged
shahzebsiddiqui merged 1 commit intodevelfrom Jan 13, 2023
Merged
Conversation
it doesn't print the exception message automatically instead we call method get_exception() to retrieve exception message. During invocation of BuildspecParser we can catch the base exception BuildspecError instead of catching every type of exception that is a subclass of BuildspecError Make use of print instead of console.print to print exception message due to errors that can occur when printing exception message
Codecov ReportBase: 71.41% // Head: 71.38% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## devel #1340 +/- ##
==========================================
- Coverage 71.41% 71.38% -0.03%
==========================================
Files 57 57
Lines 6093 6098 +5
Branches 1081 1084 +3
==========================================
+ Hits 4351 4353 +2
- Misses 1740 1743 +3
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
shahzebsiddiqui
deleted the
remove_print_traceback_during_validation_error
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.