-
-
Notifications
You must be signed in to change notification settings - Fork 21
Remove option buildtest build --disable-executor-check #1500
Copy link
Copy link
Closed
Description
@Mariamajib i am assigning this task to you
TODO
- Remove option from argparse file https://github.com/buildtesters/buildtest/blob/devel/buildtest/cli/__init__.py
- Remove option from bash completion script
- Remove logic for validation in config.py
Lines 122 to 151 in 1f63db4
def validate(self, validate_executors=True, moduletool=None): """This method validates the site configuration with schema and checks executor setting. Args: validate_executors (bool): Check executor settings. This is the default behavior but can be disabled moduletool (bool, optional): Check whether module system (Lmod, environment-modules) match what is specified in configuration file. Valid options are ``Lmod``, ``environment-modules`` """ logger.debug(f"Loading default settings schema: {DEFAULT_SETTINGS_SCHEMA}") config_schema = load_schema(DEFAULT_SETTINGS_SCHEMA) logger.debug( f"Validating configuration file with schema: {DEFAULT_SETTINGS_SCHEMA}" ) custom_validator(recipe=self.config, schema=config_schema) logger.debug("Validation was successful") if validate_executors: self._executor_check() if ( self.target_config.get("moduletool") != "N/A" and self.target_config.get("moduletool") != moduletool ): raise ConfigurationError( self.config, self.file, f"There is a module tool mismatch, we have detected '{moduletool}' but configuration property 'moduletool' specifies '{self.target_config['moduletool']}'", ) - Remove logic in main.py and remove variable in method invocation
Lines 125 to 128 in 1f63db4
validate_executors = True # if buildtest build --disable-executor-check is specified store the value if hasattr(args, "disable_executor_check"): validate_executors = args.disable_executor_check Line 135 in 1f63db4
configuration.validate(validate_executors, moduletool=system.system["moduletool"])
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels