-
-
Notifications
You must be signed in to change notification settings - Fork 21
[FEATURE]: add pagination support for 'buildtest history' #1211
Copy link
Copy link
Closed
Labels
new featureNew Feature in buildtest such as command line or improvement to buildspecNew Feature in buildtest such as command line or improvement to buildspec
Description
Please describe your feature request
Similar to #1210, let's add pagination support for buildtest history command via --pager and -p option.
Let's remove the -p option from buildtest history list and move this up a level to buildtest history --pager
(buildtest) ~/Documents/github/buildtest/ [update_buildtest_help+*] buildtest history list -h
usage: buildtest [options] [COMMANDS] history list [-h] [-n] [-t] [--pager]
optional arguments:
-h, --help show this help message and exit
-n, --no-header Do not print header columns in terse output (--terse)
-t, --terse Print output in machine readable format
--pager Enabling PAGING when viewing result
We should have buildtest history --pager list work exactly how buildtest history list --pager works.
The pagination for buildtest history query should work in the following cases
buildtest history -p query 0buildtest history -p query 0 --output
Action Item
- Add
--pagerand-poption in https://github.com/buildtesters/buildtest/blob/devel/buildtest/cli/__init__.py and also remove this frombuildtest history list --pager. - Add support of pagination for commands
buildtest history listandbuildtest history query <id>. https://github.com/buildtesters/buildtest/blob/devel/buildtest/cli/history.py - Add option to bash completion script https://github.com/buildtesters/buildtest/blob/devel/bash_completion.sh and make sure
buildtest history list --pageroption is removed from bash completion - Add regression test for pagination in https://github.com/buildtesters/buildtest/blob/devel/tests/cli/test_history.py
- Add a row entry in
buildtest help historypertaining to pagination in https://github.com/buildtesters/buildtest/blob/devel/buildtest/cli/help.py
Post question in Slack
- I agree that I posted my question in slack before creating this issue
Is there an existing issue
- I confirm there is no existing issue for this issue
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
new featureNew Feature in buildtest such as command line or improvement to buildspecNew Feature in buildtest such as command line or improvement to buildspec