fix: remove gocloud to reduce the surface area of the library #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the gocloud.dev dependency to reduce the library's dependency footprint. The change simplifies the blob storage implementation by eliminating support for GCS and Azure backends, retaining only S3 support through the direct AWS SDK implementation.
Key changes:
- Removed gocloud.dev-based blob storage implementation and its tests
- Simplified blob store initialization to use only the S3 transfer client
- Removed multiple indirect dependencies related to gocloud and its cloud provider integrations
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| store/gocloud_test.go | Removed all tests for the gocloud-based blob storage implementation |
| store/gocloud.go | Removed the entire GocloudBlob implementation that wrapped gocloud.dev functionality |
| store/blob.go | Simplified NewBlobStore to directly use S3Blob, removing gocloud fallback logic and unsupported storage schemes |
| go.mod | Removed gocloud.dev and related transitive dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Moving zstash to a library highighted the sizable footprint of deps added by gocloud, for this reason I am going to remove it for now. We will need to address compatiblity with azure and gcp through integrations with existing machinery in the agent.
wolfeidau
force-pushed
the
fix_remove_gocloud
branch
from
4df7f15 to
fea2f7c
Compare
quinn-diesel
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving zstash to a library highighted the sizable footprint of deps added by gocloud, for this reason I am going to remove it for now.
We will need to address compatiblity with azure and gcp through integrations with existing machinery in the agent.