fix: prepend leading slash to endpoints to prevent malformed URLs #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `bk api` without a leading slash (e.g., `bk api "pipelines/dummy/builds/5085"`), the endpoint was concatenated directly to the organization prefix, resulting in malformed URLs like `v2/organizations/org-slugpipelines/dummy/builds/5085` instead of `v2/organizations/org-slug/pipelines/dummy/builds/5085`. Changes: - Extract endpoint building logic into `buildFullEndpoint()` function - Prepend `/` to endpoints that don't start with one - Add tests covering a few endpoint formats (with/without slash, analytics endpoints, empty endpoints, .etc.)
mcncl
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stumbled upon the issue while looking at the #613.
While the issue from #613 doesn't seem to be present anymore (tested using latest version 3.17.2), I discovered a different issue.
When using
bk apiwithout a leading slash (e.g.,bk api "pipelines/dummy/builds/5085"), the endpoint was concatenated directly to the organization prefix, resulting in malformed URLs likev2/organizations/org-slugpipelines/dummy/builds/5085instead ofv2/organizations/org-slug/pipelines/dummy/builds/5085.Changes
buildFullEndpoint()function/to endpoints that don't start with oneTesting
go test ./...)go fmt ./...)Disclosures / Credits
I did not use "AI" tools at all.