Skip to content

Conversation

@petetomasik
Copy link
Contributor

Description

Fixes #611

The recent migration from Cobra to Kong introduced a regression where configuration validation was added to the configure command itself, causing a chicken and egg scenario.

Changes

Instead of adding the specific configure commands to CommandsNotRequiringToken, used strings.HasPrefix() to apply exemption to all configure commands.

Testing

  • Tests have run locally (with go test ./...)
  • Code is formatted (with go fmt ./...)

Built local binary and successfully tested changes with previously failing bk configure --org <org-slug> --token <token> command.

Disclosures / Credits

Used Claude Code to validate the issue, identify the bug (and how it was introduced) and implement a guided fix.

@petetomasik petetomasik requested a review from a team as a code owner January 6, 2026 19:17
Copy link

@navignaw navignaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My approval has no clout but lgtm - thanks for the quick fix! :)

@mcncl mcncl merged commit 1901ea7 into main Jan 6, 2026
1 check passed
@mcncl mcncl deleted the SUP-5913-skip-token-check-configure-cmds branch January 6, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: bk configure fails unconditionally with "you must set a valid API token"

4 participants