Skip to content

Conversation

@JoeColeman95
Copy link
Contributor

Description

This PR removes all dependencies and dead code for Cobra, and removes Viper, as such slightly refactors config
Replaced YAML handling to goccy/go-yaml as I realised that the ghodss/yaml package was abandoned

Changes

  • Removed dead code, hence a lot of deletions (remnants from removing Cobra)
  • Removed dependencies on Cobra where relevant
  • Removed dependencies on Viper (slight refactor to config and surrounding tests)
  • Moved from ghodss/yaml to goccy/go-yaml as it's actively developed
  • Ran go mod tidy to clean up imports and indirects
  • Updated output flag across the board to enum to json, yaml, text and fixed hardcoded values for default

Testing

  • [ X ] Tests have run locally (with go test ./...)
  • [ X ] Code is formatted (with go fmt ./...)

Disclosures / Credits

Took a lot of pleasure removing everything, no AI stealing my joy.

@JoeColeman95 JoeColeman95 requested a review from a team as a code owner January 5, 2026 16:43
@JoeColeman95 JoeColeman95 changed the title Sup 4491/remove cobra Removing Cobra and Viper Jan 5, 2026
tomowatt
tomowatt previously approved these changes Jan 5, 2026
Copy link
Member

@tomowatt tomowatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are a machine 💪

@JoeColeman95 JoeColeman95 enabled auto-merge (squash) January 5, 2026 17:09
@JoeColeman95 JoeColeman95 disabled auto-merge January 5, 2026 17:09
@JoeColeman95 JoeColeman95 enabled auto-merge (squash) January 5, 2026 17:10
@JoeColeman95 JoeColeman95 merged commit 18a6543 into main Jan 5, 2026
1 check passed
@JoeColeman95 JoeColeman95 deleted the SUP-4491/Remove-Cobra branch January 5, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants