respect --no-input flag in pipeline picker #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add PickOneWithNoInput() function to accept noInput parameter - Add PickOneWithFactory() function that uses factory's NoInput flag - Update all 11 command files to use PickOneWithFactory(f) - Add safety check to prevent panic when pipeline not found - Fixes issue where pipeline picker ignored --no-input flag - Makes CLI automation-friendly and CI/CD ready PBI: #SUP-5609
mcncl
reviewed
Dec 16, 2025
Contributor
|
Investigating a little, we should probably opt to keep use of mattn's library. |
Contributor
Author
|
@mcncl I reverted prompt.go to mattn/go-isatty to match the existing codebase |
- Resolve conflicts in internal/io/prompt.go - Update cmd/pipeline/copy.go to use PickOneWithFactory - Keep TTY detection using mattn/go-isatty for consistency
We don't use this file anymore
mcncl
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all tests related to this fix passed :
internal/pipeline/resolver — PASS
internal/io — PASS
cmd/build — PASS