Move configure cmd to Kong
#602
Conversation
| // Get organization slug | ||
| org, err := promptForInput("Organization slug: ", false) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if org == "" { | ||
| return errors.New("organization slug cannot be empty") | ||
| } |
There was a problem hiding this comment.
We no longer ask for the org, so bk configure add will fail with no organisation supplied or something, did this get tested?
There was a problem hiding this comment.
@mcncl , yes it got tested. I have removed the prompts and it should be provided as a flag now --org. It will error if the flag is not provided. I've updated the PR description. Maybe I should remove it as a flag and change it to an argument. 🤔
There was a problem hiding this comment.
@lizrabuya it's fine if we want to go via --org/organization, however the --help output says to run this which is incorrect;
bk configure add
There was a problem hiding this comment.
Perhaps we should note in the help output examples that we need those?
|
Need more changes on the |
Description
Migrate
configureandconfigure addcommands to Kong.Kong does not handle the pattern well for an optional subcommand like
bk configure add. The approach was to create a default command that is hidden and takes thebk configure.Changes
/pkg/cmd/configure/*to/cmd/configure/*--orgflag now. This will error if the flag is not provided.Testing
go test ./...)go fmt ./...)Disclosures / Credits
Consulted Claude on the best approach to implement the optional subcommand in Kong framework.