chore: remove duplicate typing and utilise generic #601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have implemented duplicate typing in the CLI for rendering output, which might cause drift if
go-buildkitestructs change and we utilise them in the CLI but don't update our models.Changes
Viewablemethod which renders our output for us, without the need for individual modelsViewablemethodTesting
go test ./...)go fmt ./...)Disclosures / Credits
I used Claude (via OpenCode) to identify duplicate typing that we could remove; it scanned the files for locations where we create a
structwhich already exists ingo-buildkite. This allowed me to create a function using generics ([T]) which performs our text based rendering, removing the need for packages likelipgloss