SUP-4496, SUP-4951, SUP-4952, SUP-4954, SUP-4955: Remove Spinner Dependencies #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Mykematt
commented
Nov 24, 2025
Mykematt
commented
- Added global --quiet flag to suppress progress output
- Stored in Factory.Quiet and propagated to commands
- Removed charmbracelet/huh/spinner dependency
- New simple spinner using ... animation, writes to stderr
- Respects quiet mode and non-TTY environments
- SpinWhile() now takes *factory.Factory parameter
- Removed spinner from StoppableAgent bubbletea model
- Handles non-TTY stdin properly for piped input
- Job cancel: passes display ID (not GraphQL ID) to spinner message
scadu
reviewed
Nov 25, 2025
Mykematt
force-pushed
the
Ola-Spinner
branch
from
87f6dee to
e115561
Compare
scadu
reviewed
Nov 26, 2025
- Stored in Factory.Quiet and propagated to commands - Removed previously implemented global --yes and --input from subcommand to command level - Removed charmbracelet/huh/spinner dependency - New simple spinner using ... animation, writes to stderr - Respects quiet mode and non-TTY environments - SpinWhile() now takes *factory.Factory parameter - Removed spinner from StoppableAgent bubbletea model - Handles non-TTY stdin properly for piped input - Job cancel: passes display ID (not GraphQL ID) to spinner message
- Fix TTY detection consistency: use os.Stdout.Fd() in spinner.go - Propagate quiet flag to agent list TUI (suppresses status messages) - Propagate quiet flag to agent stop TUI (suppresses intermediate states) - Update tests for new quiet parameter
…inWhile signature - Added --quiet/-q flag to Kong CLI struct and GlobalFlags interface - Updated all Kong build commands to set f.Quiet from globals.IsQuiet() - Updated SpinWhile calls in cmd/build/*.go to use new (f, msg, fn) signature - Added --quiet to buildCobraArgs() bridge for Cobra command compatibility - Updated factory.go comment to reflect current Kong/Cobra status
Mykematt
force-pushed
the
Ola-Spinner
branch
from
d1361a6 to
3557ed8
Compare
scadu
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.