respect --no-input flag in pipeline picker (#604)

ivannalisetska · web-flow · commit 01476773a818 · 2025-12-17T10:29:09.000+11:00
* fix(pipeline): respect --no-input flag in pipeline picker

- Add PickOneWithNoInput() function to accept noInput parameter
- Add PickOneWithFactory() function that uses factory's NoInput flag
- Update all 11 command files to use PickOneWithFactory(f)
- Add safety check to prevent panic when pipeline not found
- Fixes issue where pipeline picker ignored --no-input flag
- Makes CLI automation-friendly and CI/CD ready

PBI: #SUP-5609

* chore: remove CHANGELOG.md

We don't use this file anymore
diff --git a/CHANGELOG.md b/CHANGELOG.md
diff --git a/cmd/artifacts/list.go b/cmd/artifacts/list.go
@@ -75,8 +75,8 @@ func (c *ListCmd) Run(kongCtx *kong.Context, globals cli.GlobalFlags) error {
 	// Resolve a pipeline based on how bk build resolves the pipeline
 	pipelineRes := pipelineResolver.NewAggregateResolver(
 		pipelineResolver.ResolveFromFlag(c.Pipeline, f.Config),
-		pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOne),
-		pipelineResolver.ResolveFromRepository(f, pipelineResolver.CachedPicker(f.Config, pipelineResolver.PickOne, f.GitRepository != nil)),
+		pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOneWithFactory(f)),
+		pipelineResolver.ResolveFromRepository(f, pipelineResolver.CachedPicker(f.Config, pipelineResolver.PickOneWithFactory(f), f.GitRepository != nil)),
 	)
 
 	// We resolve a build an optional argument or positional argument
diff --git a/cmd/build/cancel.go b/cmd/build/cancel.go
@@ -49,8 +49,8 @@ func (c *CancelCmd) Run(kongCtx *kong.Context, globals cli.GlobalFlags) error {
 
 	pipelineRes := pipelineResolver.NewAggregateResolver(
 		pipelineResolver.ResolveFromFlag(c.Pipeline, f.Config),
-		pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOne),
-		pipelineResolver.ResolveFromRepository(f, pipelineResolver.CachedPicker(f.Config, pipelineResolver.PickOne, f.GitRepository != nil)),
+		pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOneWithFactory(f)),
+		pipelineResolver.ResolveFromRepository(f, pipelineResolver.CachedPicker(f.Config, pipelineResolver.PickOneWithFactory(f), f.GitRepository != nil)),
 	)
 
 	args := []string{c.BuildNumber}
diff --git a/cmd/build/create.go b/cmd/build/create.go
@@ -65,8 +65,8 @@ func (c *CreateCmd) Run(kongCtx *kong.Context, globals cli.GlobalFlags) error {
 
 	resolvers := resolver.NewAggregateResolver(
 		resolver.ResolveFromFlag(c.Pipeline, f.Config),
-		resolver.ResolveFromConfig(f.Config, resolver.PickOne),
-		resolver.ResolveFromRepository(f, resolver.CachedPicker(f.Config, resolver.PickOne, f.GitRepository != nil)),
+		resolver.ResolveFromConfig(f.Config, resolver.PickOneWithFactory(f)),
+		resolver.ResolveFromRepository(f, resolver.CachedPicker(f.Config, resolver.PickOneWithFactory(f), f.GitRepository != nil)),
 	)
 
 	resolvedPipeline, err := resolvers.Resolve(ctx)
diff --git a/cmd/build/download.go b/cmd/build/download.go
@@ -67,8 +67,8 @@ func (c *DownloadCmd) Run(kongCtx *kong.Context, globals cli.GlobalFlags) error
 	// 3. find pipelines matching the current repository from the API
 	pipelineRes := pipelineResolver.NewAggregateResolver(
 		pipelineResolver.ResolveFromFlag(c.Pipeline, f.Config),
-		pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOne),
-		pipelineResolver.ResolveFromRepository(f, pipelineResolver.CachedPicker(f.Config, pipelineResolver.PickOne, f.GitRepository != nil)),
+		pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOneWithFactory(f)),
+		pipelineResolver.ResolveFromRepository(f, pipelineResolver.CachedPicker(f.Config, pipelineResolver.PickOneWithFactory(f), f.GitRepository != nil)),
 	)
 
 	// we resolve a build based on the following rules:
diff --git a/cmd/build/list.go b/cmd/build/list.go
@@ -345,7 +345,7 @@ func (c *ListCmd) fetchBuilds(ctx context.Context, f *factory.Factory, org strin
 func (c *ListCmd) getBuildsByPipeline(ctx context.Context, f *factory.Factory, org string, listOpts *buildkite.BuildsListOptions) ([]buildkite.Build, error) {
 	pipelineRes := pipelineResolver.NewAggregateResolver(
 		pipelineResolver.ResolveFromFlag(c.Pipeline, f.Config),
-		pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOne),
+		pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOneWithFactory(f)),
 	)
 
 	pipeline, err := pipelineRes.Resolve(ctx)
diff --git a/cmd/build/rebuild.go b/cmd/build/rebuild.go
@@ -69,8 +69,8 @@ func (c *RebuildCmd) Run(kongCtx *kong.Context, globals cli.GlobalFlags) error {
 	// 3. find pipelines matching the current repository from the API
 	pipelineRes := pipelineResolver.NewAggregateResolver(
 		pipelineResolver.ResolveFromFlag(c.Pipeline, f.Config),
-		pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOne),
-		pipelineResolver.ResolveFromRepository(f, pipelineResolver.CachedPicker(f.Config, pipelineResolver.PickOne, f.GitRepository != nil)),
+		pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOneWithFactory(f)),
+		pipelineResolver.ResolveFromRepository(f, pipelineResolver.CachedPicker(f.Config, pipelineResolver.PickOneWithFactory(f), f.GitRepository != nil)),
 	)
 
 	// we resolve a build based on the following rules:
diff --git a/cmd/build/view.go b/cmd/build/view.go
@@ -83,8 +83,8 @@ func (c *ViewCmd) Run(kongCtx *kong.Context, globals cli.GlobalFlags) error {
 	// Resolve pipeline first
 	pipelineRes := pipelineResolver.NewAggregateResolver(
 		pipelineResolver.ResolveFromFlag(opts.Pipeline, f.Config),
-		pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOne),
-		pipelineResolver.ResolveFromRepository(f, pipelineResolver.CachedPicker(f.Config, pipelineResolver.PickOne, f.GitRepository != nil)),
+		pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOneWithFactory(f)),
+		pipelineResolver.ResolveFromRepository(f, pipelineResolver.CachedPicker(f.Config, pipelineResolver.PickOneWithFactory(f), f.GitRepository != nil)),
 	)
 
 	// Resolve build options
diff --git a/cmd/build/watch.go b/cmd/build/watch.go
@@ -73,8 +73,8 @@ func (c *WatchCmd) Run(kongCtx *kong.Context, globals cli.GlobalFlags) error {
 
 	pipelineRes := pipelineResolver.NewAggregateResolver(
 		pipelineResolver.ResolveFromFlag(c.Pipeline, f.Config),
-		pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOne),
-		pipelineResolver.ResolveFromRepository(f, pipelineResolver.CachedPicker(f.Config, pipelineResolver.PickOne, f.GitRepository != nil)),
+		pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOneWithFactory(f)),
+		pipelineResolver.ResolveFromRepository(f, pipelineResolver.CachedPicker(f.Config, pipelineResolver.PickOneWithFactory(f), f.GitRepository != nil)),
 	)
 
 	optionsResolver := options.AggregateResolver{
diff --git a/cmd/job/list.go b/cmd/job/list.go
@@ -580,7 +580,7 @@ func jobListOptionsFromFlags(opts *jobListOptions) (*buildkite.BuildsListOptions
 func getBuildsByPipeline(ctx context.Context, f *factory.Factory, org, pipelineFlag string, listOpts *buildkite.BuildsListOptions) ([]buildkite.Build, error) {
 	pipelineRes := pipelineResolver.NewAggregateResolver(
 		pipelineResolver.ResolveFromFlag(pipelineFlag, f.Config),
-		pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOne),
+		pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOneWithFactory(f)),
 	)
 
 	pipeline, err := pipelineRes.Resolve(ctx)
diff --git a/cmd/pipeline/copy.go b/cmd/pipeline/copy.go
@@ -130,8 +130,8 @@ func (c *CopyCmd) resolveSourcePipeline(ctx context.Context, f *factory.Factory)
 
 	pipelineRes := resolver.NewAggregateResolver(
 		resolver.ResolveFromPositionalArgument(args, 0, f.Config),
-		resolver.ResolveFromConfig(f.Config, resolver.PickOne),
-		resolver.ResolveFromRepository(f, resolver.CachedPicker(f.Config, resolver.PickOne, f.GitRepository != nil)),
+		resolver.ResolveFromConfig(f.Config, resolver.PickOneWithFactory(f)),
+		resolver.ResolveFromRepository(f, resolver.CachedPicker(f.Config, resolver.PickOneWithFactory(f), f.GitRepository != nil)),
 	)
 
 	p, err := pipelineRes.Resolve(ctx)
diff --git a/cmd/pipeline/view.go b/cmd/pipeline/view.go
@@ -63,8 +63,8 @@ func (c *ViewCmd) Run(kongCtx *kong.Context, globals cli.GlobalFlags) error {
 
 	pipelineRes := resolver.NewAggregateResolver(
 		resolver.ResolveFromPositionalArgument(args, 0, f.Config),
-		resolver.ResolveFromConfig(f.Config, resolver.PickOne),
-		resolver.ResolveFromRepository(f, resolver.CachedPicker(f.Config, resolver.PickOne, f.GitRepository != nil)),
+		resolver.ResolveFromConfig(f.Config, resolver.PickOneWithFactory(f)),
+		resolver.ResolveFromRepository(f, resolver.CachedPicker(f.Config, resolver.PickOneWithFactory(f), f.GitRepository != nil)),
 	)
 
 	pipeline, err := pipelineRes.Resolve(ctx)
diff --git a/internal/io/prompt.go b/internal/io/prompt.go
@@ -2,8 +2,11 @@ package io
 
 import (
 	"fmt"
+	"os"
 	"strconv"
 	"strings"
+
+	"github.com/mattn/go-isatty"
 )
 
 const (
@@ -14,12 +17,19 @@ const (
 // PromptForOne will show the list of options to the user, allowing them to select one to return.
 // It's possible for them to choose none or cancel the selection, resulting in an error.
 // If noInput is true, it will fail instead of prompting.
+// If there's no TTY available, it will also fail instead of prompting.
 //
 // For global flag support requirements, see the Confirm() function documentation.
 func PromptForOne(resource string, options []string, noInput bool) (string, error) {
 	if noInput {
 		return "", fmt.Errorf("interactive input required but --no-input flag is set")
 	}
+
+	// Check if we have a TTY available - if not, treat it as if noInput is true
+	if !isatty.IsTerminal(os.Stdin.Fd()) {
+		return "", fmt.Errorf("interactive input required but no TTY available")
+	}
+
 	var message string
 	switch resource {
 	case "pipeline":
diff --git a/internal/pipeline/resolver/picker.go b/internal/pipeline/resolver/picker.go

Original file line number	Diff line number	Diff line change
`@@ -49,8 +49,8 @@ func (c CancelCmd) Run(kongCtx kong.Context, globals cli.GlobalFlags) error {`
`49`	`49`
`50`	`50`	`pipelineRes := pipelineResolver.NewAggregateResolver(`
`51`	`51`	`pipelineResolver.ResolveFromFlag(c.Pipeline, f.Config),`
`52`		`- pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOne),`
`53`		`- pipelineResolver.ResolveFromRepository(f, pipelineResolver.CachedPicker(f.Config, pipelineResolver.PickOne, f.GitRepository != nil)),`
	`52`	`+ pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOneWithFactory(f)),`
	`53`	`+ pipelineResolver.ResolveFromRepository(f, pipelineResolver.CachedPicker(f.Config, pipelineResolver.PickOneWithFactory(f), f.GitRepository != nil)),`
`54`	`54`	`)`
`55`	`55`
`56`	`56`	`args := []string{c.BuildNumber}`
Original file line number	Diff line number	Diff line change
`@@ -65,8 +65,8 @@ func (c CreateCmd) Run(kongCtx kong.Context, globals cli.GlobalFlags) error {`
`65`	`65`
`66`	`66`	`resolvers := resolver.NewAggregateResolver(`
`67`	`67`	`resolver.ResolveFromFlag(c.Pipeline, f.Config),`
`68`		`- resolver.ResolveFromConfig(f.Config, resolver.PickOne),`
`69`		`- resolver.ResolveFromRepository(f, resolver.CachedPicker(f.Config, resolver.PickOne, f.GitRepository != nil)),`
	`68`	`+ resolver.ResolveFromConfig(f.Config, resolver.PickOneWithFactory(f)),`
	`69`	`+ resolver.ResolveFromRepository(f, resolver.CachedPicker(f.Config, resolver.PickOneWithFactory(f), f.GitRepository != nil)),`
`70`	`70`	`)`
`71`	`71`
`72`	`72`	`resolvedPipeline, err := resolvers.Resolve(ctx)`
Original file line number	Diff line number	Diff line change
`@@ -345,7 +345,7 @@ func (c ListCmd) fetchBuilds(ctx context.Context, f factory.Factory, org strin`
`345`	`345`	`func (c ListCmd) getBuildsByPipeline(ctx context.Context, f factory.Factory, org string, listOpts *buildkite.BuildsListOptions) ([]buildkite.Build, error) {`
`346`	`346`	`pipelineRes := pipelineResolver.NewAggregateResolver(`
`347`	`347`	`pipelineResolver.ResolveFromFlag(c.Pipeline, f.Config),`
`348`		`- pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOne),`
	`348`	`+ pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOneWithFactory(f)),`
`349`	`349`	`)`
`350`	`350`
`351`	`351`	`pipeline, err := pipelineRes.Resolve(ctx)`
Original file line number	Diff line number	Diff line change
`@@ -73,8 +73,8 @@ func (c WatchCmd) Run(kongCtx kong.Context, globals cli.GlobalFlags) error {`
`73`	`73`
`74`	`74`	`pipelineRes := pipelineResolver.NewAggregateResolver(`
`75`	`75`	`pipelineResolver.ResolveFromFlag(c.Pipeline, f.Config),`
`76`		`- pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOne),`
`77`		`- pipelineResolver.ResolveFromRepository(f, pipelineResolver.CachedPicker(f.Config, pipelineResolver.PickOne, f.GitRepository != nil)),`
	`76`	`+ pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOneWithFactory(f)),`
	`77`	`+ pipelineResolver.ResolveFromRepository(f, pipelineResolver.CachedPicker(f.Config, pipelineResolver.PickOneWithFactory(f), f.GitRepository != nil)),`
`78`	`78`	`)`
`79`	`79`
`80`	`80`	`optionsResolver := options.AggregateResolver{`
Original file line number	Diff line number	Diff line change
`@@ -580,7 +580,7 @@ func jobListOptionsFromFlags(opts jobListOptions) (buildkite.BuildsListOptions`
`580`	`580`	`func getBuildsByPipeline(ctx context.Context, f factory.Factory, org, pipelineFlag string, listOpts buildkite.BuildsListOptions) ([]buildkite.Build, error) {`
`581`	`581`	`pipelineRes := pipelineResolver.NewAggregateResolver(`
`582`	`582`	`pipelineResolver.ResolveFromFlag(pipelineFlag, f.Config),`
`583`		`- pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOne),`
	`583`	`+ pipelineResolver.ResolveFromConfig(f.Config, pipelineResolver.PickOneWithFactory(f)),`
`584`	`584`	`)`
`585`	`585`
`586`	`586`	`pipeline, err := pipelineRes.Resolve(ctx)`