Skip to content

Conversation

@zhming0
Copy link
Contributor

@zhming0 zhming0 commented Jan 7, 2026

Description

BUILDKITE_KUBERNETES_EXEC is a legacy environment variable. It was used to activate the socket on the bootstrap command, and to activate the socket server on buildkite-agent start. The former has been superseded by this kubernetes-bootstrap command.

But we want to keep this env var because some users depend on it as a k8s environment detection mechanism.

Context

PS-1525

Changes

  • Set BUILDKITE_KUBERNETES_EXEC to true for bootstrap command spawed by kubernetes-bootstrap.
  • Move the global Kubernetes flag to start command, as that is the only place it is still having any impact.

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go tool gofumpt -extra -w .)

Disclosures / Credits

Human + LLM

@zhming0 zhming0 requested a review from a team January 7, 2026 23:06
@zhming0 zhming0 merged commit 42e7b46 into main Jan 8, 2026
2 checks passed
@zhming0 zhming0 deleted the ming/ps-1525 branch January 8, 2026 05:05
@zhming0 zhming0 mentioned this pull request Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants