PS-1525: keep BUILDKITE_KUBERNETES_EXEC true for k8s bootstrap #3658
+14
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BUILDKITE_KUBERNETES_EXECis a legacy environment variable. It was used to activate the socket on the bootstrap command, and to activate the socket server onbuildkite-agent start. The former has been superseded by thiskubernetes-bootstrapcommand.But we want to keep this env var because some users depend on it as a k8s environment detection mechanism.
Context
PS-1525
Changes
BUILDKITE_KUBERNETES_EXECto true for bootstrap command spawed bykubernetes-bootstrap.startcommand, as that is the only place it is still having any impact.Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go tool gofumpt -extra -w .)Disclosures / Credits
Human + LLM