Standardize artifact S3 credential loading #3559
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than using an entirely custom chain, simply take the default credential chain & prepend the buildkite-specific provider. I am specifically interested in changing this as the shared configuration `~/.aws/config` isn't currently supported with this custom setup :)
csweeney-plaid
changed the title
Contributor
|
Thanks for raising this one @csweeney-plaid! The version with #3554 in it is out now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BUILDKITE_S3overrides)~/.aws/configand also normalizes the credential loading process here vs the AWS norms.Changes
buildkite-agent artifact upload/download(not a visible api change)Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)Disclosures / Credits