PS-1302: refresh checkout root file handle after checkout hook #3546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhming0
commented
Oct 20, 2025
Comment on lines
+315
to
+323
| // After everything, we need to refresh checkout root. | ||
| // This is because checkout hook might re-create the checkout root folder entirely, deprecating e.checkoutRoot. | ||
| if err := e.refreshCheckoutRoot(); err != nil { |
Contributor
Author
There was a problem hiding this comment.
This is pretty much the actual change.
All other diff are just moving codes around for better readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have false negative
Vendored plugin path "..." must be a directory within the checked-out repositoryerror, when a checkout global hook or plugin hook recreated the checkout directory, and as part the process if the hook inject some plugins/hooks into the directory.Closes #3530
Context
PS-1302
Changes
Refresh
e.checkoutRootafter allcheckoutbehavior.Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)The QA is mostly relying on local testing. It highlight the need of comprehensive integration test suite.
Disclosures / Credits
I am human