Add --literal and --delimiter flags to artifact upload #3543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
ps-1307-literal-upload
branch
2 times, most recently
from
598b2c2 to
59f2fd4
Compare
wolfeidau
requested changes
Oct 20, 2025
Member
wolfeidau
left a comment
wolfeidau
left a comment
There was a problem hiding this comment.
Just a couple of queries/observations, looks great.
DrJosh9000
force-pushed
the
ps-1307-literal-upload
branch
from
59f2fd4 to
f740667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide easier ways to specify file paths for uploading when they could be unintentionally parsed as globs, or they use the default splitting delimiter (
;).Context
Fixes #3535
Changes
--literalflag; when set, send file paths directly to the next stage--delimiterflag; use its value to split the upload paths into multiple strings (or set to empty to disable splitting)Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)Disclosures / Credits
100% free range human