Skip to content

Conversation

@DrJosh9000
Copy link
Contributor

@DrJosh9000 DrJosh9000 commented Sep 29, 2025

Description

Rather than comparing the job env vars to a fixed list, record which ones were overridden by agent configuration when they are set.

Context

Random idea I had.

Changes

Introduce a func internal to createEnvironment that wraps checking for an existing var and updating ignoredEnv.

Testing

  • Tests have run locally (with go test ./...). Buildkite employees may check this if the pipeline has run automatically.
  • Code is formatted (with go fmt ./...)

Disclosures / Credits

I did not use AI tools at all.

@DrJosh9000 DrJosh9000 requested a review from a team September 29, 2025 05:02
Copy link
Contributor

@zhming0 zhming0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense. 👍🏿

@DrJosh9000 DrJosh9000 merged commit d7dc13a into main Oct 26, 2025
1 check passed
@DrJosh9000 DrJosh9000 deleted the catch-all-ignored-vars branch October 26, 2025 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants