PS-906: configurable kubernetes-bootstrap connection timeout #3398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
reviewed
Jul 17, 2025
clicommand/global.go
Outdated
Comment on lines
118
to
125
| KubernetesBootstrapConnectionTimeoutFlag = cli.IntFlag{ | ||
| Name: "kubernetes-bootstrap-connection-timeout", | ||
| Usage: "This is intended to be used only by the Buildkite k8s stack " + | ||
| "(github.com/buildkite/agent-stack-k8s); it set the max time a container will wait " + | ||
| "to connect Agent.", | ||
| EnvVar: "BUILDKITE_KUBERNETES_BOOTSTRAP_CONNECTION_TIMEOUT", | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
We've generally not put command-specific flags in global.go. KubernetesContainerIDFlag is currently shared with bootstrap.go and kubernetes_bootstrap.go which is why it's here.
(At some point we should remove the legacy kubernetes-exec support from within bootstrap.go.)
clicommand/global.go
Outdated
| } | ||
|
|
||
| KubernetesBootstrapConnectionTimeoutFlag = cli.IntFlag{ | ||
| Name: "kubernetes-bootstrap-connection-timeout", |
Contributor
There was a problem hiding this comment.
Is this in seconds?
Should this be a cli.DurationFlag?
Contributor
|
CI is failing because the updated pipeline.yml from |
DrJosh9000
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow
kubernetes-bootstrap's connection step timeout to be configurable via a--kubernetes-bootstrap-connection-timeoutinteger flag.This is helpful in network unstable environment.
Context
part of PS-906
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)