Brotli bombs; brotli-1.2 upgrade; GeneratorReader fix#266
Merged
vanschelven merged 3 commits intomainfrom Nov 8, 2025
Merged
Conversation
This became possible with brotli 1.2.0 It is my understanding pre-this change there was basically no enforced limit on the amount of bytes "coming out" of decompressor.process(); in other words: chunk size did not apply to the most relevant (potentially blowing up) part of the equation. We had a MaxDataReader in place, but that would come "too late" since all the mem-consuming stuff would happen right in brotli_generator before any limiting would be possible. See google/brotli#1381
this was exposed when dealing with things that yield in very big chunks potentially (e.g. brotli bombs) tests are more directly on the GeneratorReader itself now rather than integrating this with particular genators-under-test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.